Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case for fallible cs() method #138

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

skaunov
Copy link

@skaunov skaunov commented Jan 21, 2024

Error handling is mocked just for example; return type for the modified method have been left incompatible as it shows the idea to the point.

Description

It's a small example on possible inconsistency when cs() is called on [T] which contains different non-null CS. I'd like to continue on this one if introduction of error handling is indeed reasonable in the crate; or receive feedback showing this is a bad idea.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

Unchecked boxes are due to the draft nature of this PR and it's purpose isn't merging but feedback to continue development in this direction.

Error handling is mocked just for example; return type for the modified
method have been left incompatible as it shows the idea to the point.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant